Fix searchbox selection highlighting #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on TextBox.xaml from Avalonia.
Fixes search box not showing any indication on what text is selected.
I'm unsure of why this is an issue, when it broke (or if it was never fixed since the Avalonia port), but it seems like the option to set the brushes for the selection was added in 2019 - I'm assuming this was missed at some point when updating Avalonia.
Side note: I noticed the indentation in the file is very inconsistent, but I decided to leave it as is for this and indent the same as adjacent code.
Before:
After:
